-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move API errors folder structure #4957
Merged
jfcalvo
merged 18 commits into
refactor/api-folder-structure-improvements
from
refactor/api-errors-structure-improvements
Jun 7, 2024
Merged
refactor: move API errors folder structure #4957
jfcalvo
merged 18 commits into
refactor/api-folder-structure-improvements
from
refactor/api-errors-structure-improvements
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for all argilla-server files
jfcalvo
changed the title
refactor: move API handlers folder structure
refactor: move API errors folder structure
Jun 6, 2024
frascuchon
approved these changes
Jun 6, 2024
…or/api-schemas-structure-improvements
…tor/api-handlers-structure-improvements
…ctor/api-errors-structure-improvements
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor/api-folder-structure-improvements #4957 +/- ##
===========================================================================
Coverage 91.40% 91.40%
===========================================================================
Files 136 136
Lines 5820 5820
===========================================================================
Hits 5320 5320
Misses 500 500
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…or/api-schemas-structure-improvements
…tor/api-handlers-structure-improvements
…ctor/api-errors-structure-improvements
Base automatically changed from
refactor/api-handlers-structure-improvements
to
refactor/api-folder-structure-improvements
June 7, 2024 11:00
…or/api-errors-structure-improvements
jfcalvo
merged commit Jun 7, 2024
12a6816
into
refactor/api-folder-structure-improvements
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR include changes moving API errors to follow this structure:
The behavior has not been changed.
Refs #4868
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist