Adding LlamaIndex docs to integrations #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignacioct
added
the
type: documentation
sdiazlor
reviewed
May 8, 2024
There was a problem hiding this comment.
LGTM. Just a few comments to align it to the rest of the tutorials:
- - If you could change the title
- - Copy and paste the Running Argilla and Set up the Environment sections
- - Maybe an introduction is not needed, but a brief explanation of what LlamaIndex is or what it does.
- - Could you remove the verbose outputs?
- - Make a reference to how is the dataset we create.
- - Review some typos
- - Change the branch to main
|
Hi! Thanks for the comments @sdiazlor . I'll implement these comments tomorrow. One quick question tho, how would you name the notebook? |
I meant, for instance: |
|
Gotcha! Everything should be ready now :) @sdiazlor |
sdiazlor
reviewed
May 10, 2024
docs/_source/tutorials_and_integrations/integrations/llama_index.ipynb
Outdated
Show resolved
Hide resolved
sdiazlor
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4798