bugfix: pulling n * chunk_size + 1
#4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
dosubot
bot
added
area: tests
for more information, see https://pre-commit.ci
frascuchon
commented
Mar 15, 2024
| @@ -68,8 +68,7 @@ def __getitem__( | |||
| offsets = list(range(start, stop, FETCHING_BATCH_SIZE)) | |||
| limits = [FETCHING_BATCH_SIZE] * len(offsets) | |||
| if stop % FETCHING_BATCH_SIZE != 0: | |||
| offsets[-1] = stop - (stop % FETCHING_BATCH_SIZE) + 1 | |||
| limits[-1] = (stop % FETCHING_BATCH_SIZE) - 1 | |||
| limits[-1] = (stop % FETCHING_BATCH_SIZE) | |||
There was a problem hiding this comment.
@alvarobartt I think I'm not missing any other case. We should just adapt the last chunk limit starting at 1 instead of 0. So % result is enough.
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4662-ki24f765kq-no.a.run.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4662 +/- ##
===========================================
- Coverage 90.13% 89.07% -1.06%
===========================================
Files 233 190 -43
Lines 12493 11666 -827
===========================================
- Hits 11261 10392 -869
- Misses 1232 1274 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alvarobartt
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes errors computing chunk limits when pulling records from some argilla dataset
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)