fix: handling errors for non-existing endpoints #4325
Merged
+48
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
jfcalvo
approved these changes
Nov 27, 2023
davidberenstein1957
approved these changes
Nov 27, 2023
…tibility-srcargillaclientsdkv1datasetsapipy-get_metadata_properties
frascuchon
deleted the
4073-bug-pythondeployment-backwards-compatibility-srcargillaclientsdkv1datasetsapipy-get_metadata_properties
branch
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4325-ki24f765kq-no.a.run.app |
leiyre
pushed a commit
that referenced
this pull request
Nov 28, 2023
…argilla-io/argilla into feature/responses-and-suggestion-filter * 'feature/responses-and-suggestion-filter' of github.com:argilla-io/argilla: fix: handling errors for non-existing endpoints (#4325)
davidberenstein1957
pushed a commit
that referenced
this pull request
Nov 29, 2023
<!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR adds a callback controller to return a proper status code and error message when a client requests a non-existing endpoint. This change will help identify incompatibility problems when using new clients over old server instances as suggested in #4073 Closes #4073 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) **How Has This Been Tested** Calling unexisting endpoints locally **Checklist** - [X] I followed the style guidelines of this project - [X] I did a self-review of my code - [X] My changes generate no new warnings - [X] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
leiyre
pushed a commit
that referenced
this pull request
Nov 29, 2023
* develop: (30 commits) chore: increase dev version release to 1.21.0 fix: responses and suggestions filter QA (#4337) feat: delete suggestion from record on search engine (#4336) feat: update suggestion from record on search engine (#4339) bug: fix bug and update test (#4341) fix: preserve `TextClassificationSettings.label_schema` order (#4332) Update issue templates feat: 🚀 support for filtering and sorting by responses and suggestions (#4160) fix: handling errors for non-existing endpoints (#4325) feat: adding utils module and functions (#4121) Update labels in github workflows (#4315) fix: correct unification implementation for `RankingQuestionStrategy` (#4295) fix: update to solve the error of integration tests in CI (#4314) docs: revisit install process (#4261) feat: increase timeout minutes for python tests (#4307) docs: docs export dataset does not apply coloring for code snippets (#4296) docs: update final section of the rag haystack blog post (#4294) feat: add multi_modal templates and update vector setting (#4283) feat: better logging bar for FeedbackDataset (#4267) refactor: ArgillaTrainer for unified variable usage (#4214) ... # Conflicts: # frontend/v1/infrastructure/repositories/RecordRepository.ts
leiyre
pushed a commit
that referenced
this pull request
Dec 5, 2023
* develop: (41 commits) chore: update dev version chore: update CHANGELOG.md before release v1.20.0 (#4357) docs: temporal update to indicate persistent storage (#4355) docs: add suggestions and responses filters and sorting (#4345) docs: add end2end example on creating a basic text-classification dataset (#4208) Fix/responses suggestions filter fine tune (#4356) Fix/responses suggestions filter fine tune (#4356) fix: Accept draft responses on dataset records creation (#4354) Feature/responses operator (#4352) Feature/responses operator (#4352) chore: increase dev version release to 1.21.0 chore: remove dev suffix for release branch fix: responses and suggestions filter QA (#4337) feat: delete suggestion from record on search engine (#4336) feat: update suggestion from record on search engine (#4339) bug: fix bug and update test (#4341) fix: preserve `TextClassificationSettings.label_schema` order (#4332) Update issue templates feat: 🚀 support for filtering and sorting by responses and suggestions (#4160) fix: handling errors for non-existing endpoints (#4325) ... # Conflicts: # frontend/v1/domain/entities/question/Question.ts # frontend/v1/domain/entities/record/Record.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a callback controller to return a proper status code and error message when a client requests a non-existing endpoint.
This change will help identify incompatibility problems when using new clients over old server instances as suggested in #4073
Closes #4073
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
Calling unexisting endpoints locally
Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)