-
Notifications
You must be signed in to change notification settings - Fork 421
feat: Implement status bar with tqdm when parsing records in from_huggingface #4132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement status bar with tqdm when parsing records in from_huggingface #4132
Conversation
Hi @Racso-3141, this looks great already. Would you be able to update the CHANGELOG.md and work on making the tqdm bar optional via a flag? |
@kursathalat, can you also explain and highlight the disable vs enable difference we found in |
26d119f
to
bb59adf
Compare
…-records-progress-bar
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
be3777f
to
317ab0e
Compare
@Racso-3141 thanks for the update could you align with the implementation and naming used here? argilla/src/argilla/client/feedback/dataset/remote/dataset.py Lines 202 to 203 in 8eeb5ac
|
Hi, I added option flag for the progress bar and updated the CHANGE.LOG |
No problem. Do we have an official style guide to refer to? Sth like the column limit and naming.
…On Mon, Nov 6, 2023 at 11:32 AM David Berenstein ***@***.***> wrote:
@Racso-3141 <https://github.com/Racso-3141> could you align with the
implementation and naming used here?
https://github.com/argilla-io/argilla/blob/8eeb5ac1d0186ee87b7707934f1d1e2efce4d0f0/src/argilla/client/feedback/dataset/remote/dataset.py#L202-L203
—
Reply to this email directly, view it on GitHub
<#4132 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOX5EQMSFBXZP6MP75T5RH3YDEGJBAVCNFSM6AAAAAA65HABNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVGM3DINJRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Racso-3141 we have the style guide defined via pre-commit. You can see the process here: https://docs.argilla.io/en/latest/community/contributing.html and https://docs.argilla.io/en/latest/community/developer_docs.html#install-code-formatting-tools. I would say |
@Racso-3141 Also thanks a lot for the help and flexibility. It is appreciated. |
34f0b27
to
e1d627b
Compare
c98cd25
to
d82c25b
Compare
for more information, see https://pre-commit.ci
Thanks @Racso-3141! The contribution is very welcome :) If you want to find another good challenge. Feel free to reach out. |
@Racso-3141 Thanks again for this PR! Just to double-check, did you fill out our contributor form? https://tally.so/r/n9XrxK |
Yes, I did. But I just submitted a new one.
…On Wed, Nov 15, 2023 at 3:15 AM David Berenstein ***@***.***> wrote:
@Racso-3141 <https://github.com/Racso-3141> Thanks again for this PR!
Just to double-check, did you fill out our contributor form?
https://tally.so/r/n9XrxK
—
Reply to this email directly, view it on GitHub
<#4132 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOX5EQM55Y4Y642CSUVXX7DYER2YLAVCNFSM6AAAAAA65HABNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJRHE4DSMZWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
It is a new feature for function from_huggingface. I implement a progress bar with tqdm for the records parsing process.
Closes #3888
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
pip install -e .
in the repo after making changes.Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)