-
Notifications
You must be signed in to change notification settings - Fork 421
feat: add filter_by
method to the ArgillaTrainer
#4120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidberenstein1957
merged 11 commits into
argilla-io:develop
from
plaguss:feat/filter-by-argilla-trainer
Nov 6, 2023
Merged
feat: add filter_by
method to the ArgillaTrainer
#4120
davidberenstein1957
merged 11 commits into
argilla-io:develop
from
plaguss:feat/filter-by-argilla-trainer
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter_by
method to the ArgillaTrainer
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 269 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
davidberenstein1957
suggested changes
Nov 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor remarks. Perhaps we can add the sort_by and could you mention it in the docs too?
Let's add the docs |
davidberenstein1957
suggested changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the functionality to filter by response_status on the
ArgillaTrainer
:Closes #3646 and #4096
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)tests/integration/client/feedback/test_trainer.py::test_trainer_with_filter_by_and_sort_by
Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)