-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sort_by
query param to listing record endpoints
#3843
feat: add sort_by
query param to listing record endpoints
#3843
Conversation
…o feature/add-sorting-by-metadata-property-values
…o feature/add-sorting-by-metadata-property-values
69b9345
to
e28b24f
Compare
feeac0b
to
354efb7
Compare
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3843-ki24f765kq-no.a.run.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little comment
Co-authored-by: Francisco Aranda <[email protected]>
…ps://github.com/argilla-io/argilla into feature/add-sorting-by-metadata-property-values
2e22582
into
feature/support-for-metadata-filtering-and-sorting
Description
This PR adds a
sort_by
query parameter to theGET /api/v1/datasets/{dataset_id}/records
,GET /api/v1/me/datasets/{dataset_id}/records
andPOST /api/v1/me/datasets/{dataset_id}/records
that allows to sort the records by using theinserted_at
,updated_at
or a metadata property, either in ascending or descending order.In addition, this PR adds the
parse_query_param
function that is meant to be used as an endpoint dependency usingfastapi.Depends
. The function is able to parse query parameters with the format:key1,key2,key3
orkey1:value1,value2,value3
.Closes #<issue_number>
Type of change
How Has This Been Tested
Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)