fix(errors): show text search detail

frontend/plugins/vuex-orm-axios.js

@@ -10,6 +10,16 @@ export default ({ $axios, app }) => {
     if (error instanceof ExpiredAuthSessionError || [401, 403].includes(code)) {
       app.$auth.logout();
     }
+
+    if (code === 400) {
+      // Add more erros once are better handled
+      return Notification.dispatch("notify", {
+        message:
+          "Error: " + JSON.stringify(error.response.data.detail || error),
+        type: "error",
+      });
+    }
+
     return Notification.dispatch("notify", {
       message: error,
       type: "error",

src/rubrix/server/commons/errors.py

@@ -55,6 +55,13 @@ def __init__(self):
         )
 
 
+class InvalidTextSearchError(HTTPException):
+    """Error related with input params in search"""
+
+    def __init__(self, detail: str):
+        super().__init__(status_code=status.HTTP_400_BAD_REQUEST, detail=detail)
+
+
 class EntityNotFoundError(HTTPException):
     """Error raised when entity not found"""
 

src/rubrix/server/commons/es_wrapper.py

@@ -1,8 +1,9 @@
 import os
+from rubrix.server.commons.errors import InvalidTextSearchError
 from typing import Any, Callable, Dict, Iterable, List, Optional
 
 import elasticsearch
-from elasticsearch import Elasticsearch, NotFoundError
+from elasticsearch import Elasticsearch, NotFoundError, RequestError
 from elasticsearch.helpers import bulk as es_bulk, scan as es_scan
 from rubrix.logging import LoggingMixin
 
@@ -86,14 +87,25 @@ def search(
         -------
 
         """
-        return self.__client__.search(
-            index=index,
-            body=query or {},
-            routing=routing,
-            track_total_hits=True,
-            rest_total_hits_as_int=True,
-            size=size,
-        )
+        try:
+            return self.__client__.search(
+                index=index,
+                body=query or {},
+                routing=routing,
+                track_total_hits=True,
+                rest_total_hits_as_int=True,
+                size=size,
+            )
+        except RequestError as rex:
+
+            if rex.error != "search_phase_execution_exception":
+                raise rex
+
+            detail = rex.info["error"]
+            detail = detail.get("root_cause")
+            detail = detail[0].get("reason") if detail else rex.info["error"]
+
+            raise InvalidTextSearchError(detail)
 
     def create_index(
         self, index: str, force_recreate: bool = False, mappings: Dict[str, Any] = None

tests/server/text_classification/test_api.py

@@ -10,6 +10,7 @@
     TextClassificationQuery,
     TextClassificationRecord,
     TextClassificationSearchResults,
+    TextClassificationSearchRequest,
 )
 
 client = TestClient(app)
@@ -433,3 +434,33 @@ def test_metadata_with_point_in_field_name():
     assert "field.one" in results.aggregations.metadata
     assert results.aggregations.metadata.get("field.one", {})["1"] == 2
     assert results.aggregations.metadata.get("field.two", {})["2"] == 2
+
+
+def test_wrong_text_query():
+    dataset = "test_wrong_text_query"
+    assert client.delete(f"/api/datasets/{dataset}").status_code == 200
+
+    response = client.post(
+        f"/api/datasets/{dataset}/TextClassification:bulk",
+        data=TextClassificationBulkData(
+            records=[
+                TextClassificationRecord(
+                    **{
+                        "id": 0,
+                        "inputs": {"text": "Esto es un ejemplo de texto"},
+                        "metadata": {"field.one": 1, "field.two": 2},
+                    }
+                ),
+            ],
+        ).json(by_alias=True),
+    )
+
+    response = client.post(
+        f"/api/datasets/{dataset}/TextClassification:search",
+        json=TextClassificationSearchRequest(
+            query=TextClassificationQuery(query_text="!")
+        ).dict(),
+    )
+
+    assert response.status_code == 400
+    assert response.json()["detail"] == "Failed to parse query [!]"