Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] allow records filtering after query returns error 500 #219

Merged
merged 2 commits into from
Jul 16, 2021
Merged

[UI] allow records filtering after query returns error 500 #219

merged 2 commits into from
Jul 16, 2021

Conversation

leiyre
Copy link
Contributor

@leiyre leiyre commented Jul 16, 2021

see #211

@leiyre leiyre requested a review from dcfidalgo July 16, 2021 09:58
@leiyre leiyre changed the title [UI] prevent displaying the error page when the query returns error 500 WIP [UI] prevent displaying the error page when the query returns error 500 Jul 16, 2021
@leiyre leiyre changed the title WIP [UI] prevent displaying the error page when the query returns error 500 [UI] allow records filtering after query returns error 500 Jul 16, 2021
@leiyre leiyre requested a review from frascuchon July 16, 2021 11:34
frascuchon
frascuchon approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@frascuchon frascuchon merged commit f78eb78 into master Jul 16, 2021
@frascuchon frascuchon deleted the fix/prevent_front_error_if_query_500_error branch August 13, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

@dcfidalgo dcfidalgo Awaiting requested review from dcfidalgo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leiyre @frascuchon