Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(security): local auth provider encapsulation #149

Merged
merged 4 commits into from
Jun 21, 2021

Conversation

frascuchon
Copy link
Member

This PR mainly works on local auth provider encapsulation and how security checks are managed from a single component.

These changes are the first of several steps to cloud auth providers integration (like Auth0 or AWS Cognito).

!!!This PR doesn't includes new features, just rewrite code for future integration steps!!!

@frascuchon frascuchon requested review from dvsrepo and ignacioct June 18, 2021 22:21
Copy link
Contributor

@ignacioct ignacioct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what I understood, it looks good to me

@frascuchon frascuchon merged commit c5874a4 into master Jun 21, 2021
frascuchon pushed a commit that referenced this pull request Jun 24, 2021
* refactor(security): encapsulate local auth provider logic

* chore: using new security auth mechanisms

* fix(auth): missing method

* ui: parameterize auth stragegy by env
@frascuchon frascuchon deleted the refactor/auth_provider_encapsulation branch August 13, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants