-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PN532: Change from I2C to HSU (Serial) #5162
Conversation
PN532: Update resource requirements in my_user_config.h
This is indeed a lot more stable. I lost the I2C comms after some hours. This one still works. |
Yup, same experience... and it does not need hardware serial since there is only data transmission when the driver actually transacts with the PN532. |
It does not work for me! |
@Jason2866 Will chat on discord as I've removed the original branch which you were testing on so that I can get a copy of the driver file you are using to compare what I changed but its working fine for me in its current form from the development branch. |
The funny change of RX and TX did it :-) |
Yeah @arendst was cleaning up my messy code :) |
It does not work for me. After reboot, it does not detect any of my NFC tags. |
Swap tx and rx in config |
@Jason2866 That works. Thanks! |
Theo explicit changed it, so as intended |
The current implementation of I2C is inefficient and slow in comparison to using HSU (Serial) so this PR removes I2C support in favour of using the device in HSU (High-Speed UART / Serial) mode.
This is after some testing was done and I2C was found to be somewhat unpredictable at times, possibly because if the slowness of the I2C support provided by the PN532 or perhaps related to the I2C implementation in the ESP8266 Arduino core - Either way, the Serial interface appears stable and runs at a lower load average than the initial I2C implementation.