LED Redux, Exposing Options through Web, Live Web Mode Switching #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g touch light switch Added LED blink patterns support and mode configuration Added blink patterns for IDLE and known error/status states, pattern play rate also setable - idle : 1s off, 1s on - error : fast (250ms - default) flashes - wifi down : 2 short flashes - mqtt down : 3 short flashes Added 'Powered' state LED blinks xor's with blink patterns - so status patterns shown Added LED status/indicator LED disable option Changed ledstate ops to use enums and mask flags - still working on figuring out the orig intent of the LED control scheme.
…g touch light switch
Added blink patterns for IDLE and known error/status states, pattern play rate also setable - idle : 1s off, 1s on - error : fast (250ms - default) flashes - wifi down : 2 short flashes - mqtt down : 3 short flashes Added 'Powered' state LED blinks xor's with blink patterns - so status patterns shown Added LED status/indicator LED disable option Changed ledstate ops to use enums and mask flags - still working on figuring out the orig intent of the LED control scheme.
…etween user/admin if using password) Added General configuration menu - Option to set LED status indicator control to allow disabling the status LED completely (for 'normal' operation); needed for controlling LED mods - Option to set Saving mode, to stop constant flash writes of current status for every single operation.. Some javascript mods - Added scripts for testing whether the client is online before attempting to reload - Scripts and code for achieving a HTTP:basic auth 'logout' - needed for user switching Notes: The webserver upgrade for user access level escalation affects all usecases of the http user validation If a password is set for the webserver, then the authorsation kicks in.. the current user is hardcoded to "user"/"password" - need to move this out If a password is expected and no valid auth is done, the the webserver will not be usable to a client - ie: client *has* to login Translations are only for English.. still need to add in the extra defines for other builds
Support for KINGARTS-N1 touch panel
Added LED blink patterns and mode blink mode configuration
WebServer updates for user access management and some function extensions
LED status enum flags are now bits.. (& cases work) - Activity state managed from global_activity.flags - replacing the LED_MQTTSUB/PUB etc state enums - Status state managed through existing global_status.flags - Power state managed from 'power' global state flag Reworked LED blinks - Blink modes are now fully patternable (not a word, but useful)
Removed references to led_disable setting
Moved MQTT enable to MQTT config (with fix so the menu does not disappear) Added Single Button mode general option (much faster response, nice to be able to enable once configured) Added autorefresh functions to all waiting screens Fixed issue with checkbox conversions
|
Too many changes together. You modified a lot of files. It is better and more readable if you make a separated pull request for every idea. |
ascillato2
requested changes
Jan 9, 2019
|
I agree.. will redo from start. |
|
Sorry.. I've stared, fought and fought and come to the conclusion that GIT is as its name.. I did manage to update and merge with the head.. but I just am not bothered enough to create and then resplice in every change into each own branch and then submit a pull.. wasted a day figuring it out first of all even how! and its not worth the time. Sorry guys, I'll maintain it separate. |
arendst
added a commit
that referenced
this pull request
Jan 10, 2019
Change web authentication (#4865)
gemu2015
pushed a commit
to gemu2015/Sonoff-Tasmota
that referenced
this pull request
Jan 27, 2019
Change web authentication (arendst#4865)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been procrastinating on this req... (while figuring bits out), so there are quite a few deviations..
Serious apologies in advance for the bungle/bundle of work here. - or any GIT weirdness...
Some suggestions - these coming from integrating this into home light switches..
(I'm concerned with the deviations that the switch I'm working with has from the sonoff devices.. I may get a sonoff to ref against) :
-- Setting LED usecase (Activity/Status/Power.. or none to disable) - bit masking for the LED
-- Managing saving to flash of state (useful.. esp for setting a default, and its a light switch - not really concerned with prev state as its managed by home integration - also just the option of reducing unnecessary flash writes.)
-- Managing single button mode (very useful after setup is complete to stop accidental fiddling! instantaneous switch response is awesome, esp for a light switch :P)
Appreciate input, ideas and critique!
There's more needed to finish some of this.. def WIP