Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf receive HEX DEC setting #3008

Closed
wants to merge 2 commits into from

Conversation

sammy2360
Copy link

hi arendst,
created a setting in setoption to switch between HEX and DEC data in the json object when an RF signal is recieved on the sonoff bridge.

i have used setoption 28 as it was labeled as spare.
i have tested this and all seems to be working as it should.

in sonoff.ino i have changed the CMND_SETOPTION index from 26 to 28 which may enable the setting for knx_enable_enhancement.
this may have to be looked at. maybe by adding ||(index == 28) instead.

thanks for all your great work.
sam

Copy link
Contributor

@ascillato ascillato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Can you modify your PR so as to leave platformio.ini file without changes?

Thanks

@sammy2360
Copy link
Author

yes ill download a fresh copy and delete the modified one. apologies.

platform.ini restored to orgiginal state
@sammy2360
Copy link
Author

ok that is the platform.ini back to the original state. it is still listed in the pr but with no changes. will that disappear? please forgive me im new to github.

@ascillato
Copy link
Contributor

Now it is perfect. 👍

Let's see what Theo say after he review it.

@arendst arendst added the enhancement Type - Enhancement that will be worked on label Jun 24, 2018
arendst added a commit that referenced this pull request Jun 25, 2018
6.0.0a
* Add command SetOption28 to switch between hex or decimal Sonoff Bridge
RF received data format (#3008)
* Add command SetOption29 to switch between hex or decimal IR received
data format
@arendst
Copy link
Owner

arendst commented Jun 25, 2018

Just implemented. Thnx.

@arendst arendst closed this Jun 25, 2018
curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 7, 2018
6.0.0a
* Add command SetOption28 to switch between hex or decimal Sonoff Bridge
RF received data format (arendst#3008)
* Add command SetOption29 to switch between hex or decimal IR received
data format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants