Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display ini to utouch #21029

Merged
merged 1 commit into from
Mar 27, 2024
Merged

display ini to utouch #21029

merged 1 commit into from
Mar 27, 2024

Conversation

gemu2015
Copy link
Contributor

Description:

replace touch entries with universal touch code

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866
Copy link
Collaborator

@arendst Can you increase patch version number when merging this (and the other related PR)?

@s-hadinger
Copy link
Collaborator

Awesome.
My only concern is that we don't gracefully manage the transition. If we include Universal Touch in the pre-compiled binaries, then all the previous configuration fail until the user updates the display.ini - and they can't update them unless they migrated to Universal Touch screen.

Is there a way that both changes don't need to be done at the same time?

Or maybe we need to leaves :TS for now until user upgrade to latest firmware?

@Jason2866 Jason2866 added the migration (breaking) changes -> new concept / function label Mar 25, 2024
@Jason2866
Copy link
Collaborator

Jason2866 commented Mar 25, 2024

Maybe a transition version, which has dedicated and Utouch driver enabled?
When this version is launched it modifies the Utouch part in display.ini and restarts with changed settings and does some touch tests (Berry script)?

EDIT: Better providing a Berry script which does the conversion on user demand. Like the safeboot conversion.

@s-hadinger
Copy link
Collaborator

Now that uTouch is default, we can merge

@Jason2866 Jason2866 merged commit b50d613 into arendst:development Mar 27, 2024
64 checks passed
@gemu2015 gemu2015 deleted the display_ini branch March 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration (breaking) changes -> new concept / function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants