Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Check for lwIP version #1940

Closed
wants to merge 1 commit into from
Closed

Add Check for lwIP version #1940

wants to merge 1 commit into from

Conversation

ascillato
Copy link
Contributor

Add Check for lwIP version

Add Check for lwIP version
arendst added a commit that referenced this pull request Feb 27, 2018
5.12.0d
 * Prep for optional MQTT drivers by separating mqtt code from
sonoff.ino to file xdrv_00_mqtt.ino
 * Add compiler check for stable
lwIP version v1.4 (#1940)
 * Add diacritics to Polish language file
(#2005)
 * Add Hungarian language file (#2024)
 * Fix MQTT TLS
fingerprint validation (#2033)
@arendst arendst closed this Feb 27, 2018
@reaper7
Copy link

reaper7 commented Feb 27, 2018

I am using a esp8266 arduino git version, in this case I do not get any error
because core_version.h contains ARDUINO_ESP8266_GIT_VER
maybe for users like me it would be good to add something similar

@arendst
Copy link
Owner

arendst commented Feb 27, 2018

No need as the problems are solved in the git version where I suppose you talk about the stage version.

@ascillato
Copy link
Contributor Author

I tested Tasmota with the new lwIP 2.4.1 release and it works with no problem 👍 . I use lwIP v2 lower memory and the firmware is a bit smaller.

@arendst have you tested it?

@arendst
Copy link
Owner

arendst commented Mar 10, 2018

Thnx for testing. Will do soon too.

@arendst
Copy link
Owner

arendst commented Mar 10, 2018

Just provided version 2.4.1 boards.txt and platform.txt specific updates for tasmota.

@KPK75
Copy link

KPK75 commented Mar 12, 2018

I did some tests with 2.4.1 and regardless of lwip it just hungs after after some time ( under minute ). Maybe this is the cause : esp8266/Arduino#4497

@ascillato
Copy link
Contributor Author

ascillato commented Mar 12, 2018 via email

@KPK75
Copy link

KPK75 commented Mar 12, 2018

ESP-01 devices. Latest dev version. First OTA then serial. All the same. No bugs. Just hungs - stops working. Do you use webserver ?

@ascillato
Copy link
Contributor Author

ascillato commented Mar 12, 2018 via email

@KPK75
Copy link

KPK75 commented Mar 13, 2018

After downgrade to 2.4.0 (lwip 1.4) it is working fine.

@KPK75
Copy link

KPK75 commented Mar 16, 2018

Found it! 2.4.1 and Sleep >0 == hung.
esp8266/Arduino#4485

@arendst arendst added enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended good tip Type - Very useful information labels Mar 16, 2018
@ascillato
Copy link
Contributor Author

ascillato commented Mar 16, 2018 via email

curzon01 pushed a commit to curzon01/Tasmota that referenced this pull request Sep 6, 2018
5.12.0d
 * Prep for optional MQTT drivers by separating mqtt code from
sonoff.ino to file xdrv_00_mqtt.ino
 * Add compiler check for stable
lwIP version v1.4 (arendst#1940)
 * Add diacritics to Polish language file
(arendst#2005)
 * Add Hungarian language file (arendst#2024)
 * Fix MQTT TLS
fingerprint validation (arendst#2033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended good tip Type - Very useful information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants