Ability to insert chip ID in update URL and MQTT client name #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the update URL contains "%d" (or "%04d"), that will be replaced by the short chip ID (chipID & 0x1fff). If it contains "%u", that will be replaced by the chip ID. The MQTT client value now supports "%06X" for the hexadecimal chip ID, "%d" for the decimal chip ID and "%04d" for the short chip ID (chip ID & 0x1fff).
|
Had that a year ago in client id and then people start using strings where integers were expected and they received exceptions everywhere. So I had to revert to a very strict way of doing things. Looking at your implementation it might work though. Investigating. |
arendst
added a commit
that referenced
this pull request
Feb 13, 2018
5.12.0b * Add serial debug info * Add optional usage of %d or %X suffices in MQTT client to append chipid (#1871) * Add optional usage of %d or %X suffices in MQTT topic to append chipid (#1871) * Add optional usage of %d or %04d in ota url to be replaced with chipid (#1871) * Add user configurable serial GPIOs to MagicHome and Arilux modules (#1887)
curzon01
pushed a commit
to curzon01/Tasmota
that referenced
this pull request
Sep 6, 2018
5.12.0b * Add serial debug info * Add optional usage of %d or %X suffices in MQTT client to append chipid (arendst#1871) * Add optional usage of %d or %X suffices in MQTT topic to append chipid (arendst#1871) * Add optional usage of %d or %04d in ota url to be replaced with chipid (arendst#1871) * Add user configurable serial GPIOs to MagicHome and Arilux modules (arendst#1887)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasmota supports the placeholder "%06X" for the MQTT client name which inserts the chip ID in hexadecimal - unfortunately, it does not support other placeholders. I have added "%d" for the chip ID in decimal, and "%04d" for the short chip ID (same as used in the hostname). This is because I identify my sonoff devices using the 4-digit hostname number and also have that in the MQTT client name.
In addition, I added support for placeholders to the OTA update URL. If the update URL contains "%d" (or "%04d"), that will be replaced by the short chip ID (chipID & 0x1fff). If it contains "%u", that will be replaced by the (long) chip ID (both in decimal).
This means, one could now compile one firmware, flash that to multiple Sonoffs, and they'd have different MQTT client names including the ID (in different variants, not just 6-digit hex), and, if the OTA url in the firmware is set correctly (containing a placeholder), the server which you load the update from knows which device requested the update - great for deploying a new testing firmware to just one device.