Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rule Trigger Comparison Operators for strings #10538

Closed
wants to merge 6 commits into from
Closed

Add Rule Trigger Comparison Operators for strings #10538

wants to merge 6 commits into from

Conversation

ortegafernando
Copy link
Contributor

Add Rule Trigger Comparison Operators for strings (contains and/or starts and ends with)

Description:

Explained here: #10208

I have created also a PR for docs.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works on Tasmota core ESP32 V.1.0.5-rc4
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Add Rule Trigger Comparison Operators for strings (contains and/or starts and ends with)
…arts and ends with)

Add Rule Trigger Comparison Operators for strings (contains and/or starts and ends with)
Add Rule Trigger Comparison Operators for strings (contains and/or starts and ends with)
Add Rule Trigger Comparison Operators for strings (contains and/or starts and ends with)
Add Rule Trigger Comparison Operators for strings (contains and/or starts and ends with)
Add Rule Trigger Comparison Operators for strings (contains and/or starts and ends with)
@ortegafernando
Copy link
Contributor Author

ortegafernando commented Jan 20, 2021

Hi, could you merge this? Thanks a lot. I understand that there is plenty of work, but this is a "little add", remember that I have also a PR in wiki documentation. Thanks.

arendst added a commit that referenced this pull request Jan 21, 2021
Add rule trigger string comparisons for EndsWith ``$>``, StartsWith ``$<`` and Contains ``$|`` (#10538)
@arendst
Copy link
Owner

arendst commented Jan 21, 2021

Merged in some way.

@arendst arendst closed this Jan 21, 2021
@ortegafernando
Copy link
Contributor Author

Remember PR in wiki

@barbudor
Copy link
Contributor

Some additions and fixes in #10779
Docs PR in tasmota/docs#610

@dusan06
Copy link

dusan06 commented Apr 12, 2021

Can someone help me! I am trying to use TDM (Tasmota device manager) NODEMCA ESP8266 with 32 pins, when I open the RULES program it cracks. Does anyone have an idea.

@barbudor
Copy link
Contributor

barbudor commented Apr 12, 2021

@dusan06 Github Issues and Pull Requests are not the right place to ask for help.
Please go to https://github.com/arendst/Tasmota/discussions
Or join the Discord support group : https://discord.gg/Ks2Kzd4

@dusan06
Copy link

dusan06 commented Apr 12, 2021

Thanx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants