Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "0x" in front of recieved IR data in hex #5431

Closed
Doc-Steve opened this issue Mar 9, 2019 · 1 comment
Closed

Add "0x" in front of recieved IR data in hex #5431

Doc-Steve opened this issue Mar 9, 2019 · 1 comment
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended

Comments

@Doc-Steve
Copy link

When receiving IR data in hex format it is formatted like this
{"Protocol":"NEC","Bits":32,"Data":"FF20DF"}

When sending the same string via irsend the Data is treated as decimal, you have to change the string to {"Protocol":"NEC","Bits":32,"Data":"0xFF20DF"}, then it works.

Suggestion: add "0x" in front of Data value when reported as hex value by IrReceived, so that receiving and sending are consistant. Thank you.
@ascillato2 ascillato2 added the enhancement Type - Enhancement that will be worked on label Mar 10, 2019
arendst added a commit that referenced this issue Mar 11, 2019
@arendst
Add 0x to IRRemote and RCSwitch
d7715d1 
Add 0x to IRRemote (SetOption29) and RCSwitch (SetOption28) received hexadecimal data (#5431)
@arendst arendst added the fixed Result - The work on the issue has ended label Mar 11, 2019
engrbm87 pushed a commit to engrbm87/Sonoff-engrbm that referenced this issue Mar 11, 2019
@arendst @engrbm87
Add 0x to IRRemote and RCSwitch
8be330c 
Add 0x to IRRemote (SetOption29) and RCSwitch (SetOption28) received hexadecimal data (arendst#5431)
@ascillato2
Copy link
Collaborator

Closing as it has been fixed. Thanks.

@CWempe CWempe mentioned this issue Sep 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Type - Enhancement that will be worked on fixed Result - The work on the issue has ended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arendst @Doc-Steve @ascillato2