Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework #2

Closed
brandonsturgeon opened this issue Jul 14, 2017 · 4 comments
Closed

Rework #2

brandonsturgeon opened this issue Jul 14, 2017 · 4 comments

Comments

@brandonsturgeon
Copy link
Contributor

brandonsturgeon commented Jul 14, 2017

Hey @areebbeigh I was intending on just adding pluralization support, but I ended up reworking a lot of the logic. I won't make a PR until we have a chance to chat (and until I get it ironed out).

I converted the plugin to a class structure, so ideally you could do:

pf = ProfanityFilter()
pf.append_words(['more', 'profane', 'words'])

print pf.censor('some of these words are fucking profane')

>some of these ***** are ******* *******

Take a look at the changes I made in this commit (I didn't do it atomically because I wasn't expecting to do so much! I got caught up in it.): brandonsturgeon@8e34e92

@areebbeigh
Copy link
Owner

areebbeigh commented Jul 14, 2017

Hi @brandonsturgeon I see you've made a lot of improvements. This is really great! Thanks! I request you to go ahead and finish up with the final touches, I'll be waiting for the final PR!

@brandonsturgeon
Copy link
Contributor Author

Sorry, as is typical of me, I sort of forgot about this. I'll add it to my list again :)

I don't think I could bring it all the way across the finish line, but I could get it to a mostly-working state and send you a pull request. What do you think about that?

@areebbeigh
Copy link
Owner

areebbeigh commented Nov 6, 2017 via email

@brandonsturgeon brandonsturgeon mentioned this issue Nov 6, 2017
@brandonsturgeon
Copy link
Contributor Author

Haha :)

I made the PR

duttonw pushed a commit that referenced this issue Nov 25, 2024
[QOLDEV-683] restore namespace-level import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants