Parser changes to match coming update to the spec for the new ruby model #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any test cases easily added for this? |
|
And can you match the indentation style? |
|
Test cases are in here: web-platform-tests/wpt#463 I assumed that you used the same test suite (though I confess I didn't look at your test system and basically ran those through a quick throwaway script). Concerning indent style, I thought I'd matched — I'll double check. |
|
Yeah, I've been using a portion of that suite, originally imported from html5lib's tree. I'm in the process of making it more maintainable / easier to update, but it's a static copy at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per http://darobin.github.io/html-ruby/. This change is being landed in the W3C specification (within the days to come), apply with caution.