Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simvastatin example with determinstic dims #2

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

acmiyaguchi
Copy link
Contributor

I was running into issues trying to display the proper names from the example final using the simvastatin example. I found out that it's because the deterministic nodes need to be annotated with dims from the group coordinates in the model. On the practice final (problem 2), my chart ends up looking like this with the correct annotations:

image

It doesn't actually help in this example because all the categorical variables are numbers, but maybe someone in the future might find this helpful.

As an aside, I had trouble setting up conda with the dependencies. I played around with poetry, but pgmpy pulls in pytorch, which has some really bad cross-platform dependency resolution (re python-poetry/poetry#4231 and python-poetry/poetry#6710).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@areding
Copy link
Owner

areding commented Dec 9, 2022

This is great, really appreciate your contribution! After the final is graded, I'll take a closer look before merging it and also update the page's attribution with your name.

@areding areding merged commit ccaea27 into areding:main Feb 2, 2023
@acmiyaguchi acmiyaguchi deleted the simvastatin branch February 3, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants