Update simvastatin example with determinstic dims #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into issues trying to display the proper names from the example final using the simvastatin example. I found out that it's because the deterministic nodes need to be annotated with dims from the group coordinates in the model. On the practice final (problem 2), my chart ends up looking like this with the correct annotations:
It doesn't actually help in this example because all the categorical variables are numbers, but maybe someone in the future might find this helpful.
As an aside, I had trouble setting up conda with the dependencies. I played around with poetry, but pgmpy pulls in pytorch, which has some really bad cross-platform dependency resolution (re python-poetry/poetry#4231 and python-poetry/poetry#6710).