Skip to content

chore(infra): consolidate infrastructure and add create-pr command#875

Merged
rchardx merged 1 commit into
mainfrom
fw/doc
Feb 2, 2026
Merged

chore(infra): consolidate infrastructure and add create-pr command#875
rchardx merged 1 commit into
mainfrom
fw/doc

Conversation

@garrett4wade

@garrett4wade garrett4wade commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Consolidate scattered infrastructure modules into a unified areal/infra package for better code organization and discoverability. This refactoring groups related infrastructure components together without changing functionality.

Related Issue

N/A (Internal refactoring)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

Checklist

  • I have read the Contributing Guide
  • I have run formatting tools (pre-commit or manual)
  • I have run relevant unit tests and they pass
  • I have added tests for new functionality
  • I have updated documentation if needed
  • My branch is up to date with main
  • This PR introduces breaking changes (if yes, fill out details below)
  • If this PR changes documentation, I have built and previewed it locally with jb build docs
  • No critical issues raised by AI reviewers (/gemini review)

Breaking Change Details (if applicable):

N/A

Additional Context

Infrastructure consolidation:

  • areal/coreareal/infra (better reflects purpose)
  • areal/controllerareal/infra/controller (logical grouping)
  • areal/platformsareal/infra/platforms (colocate platform abstractions)
  • areal/thirdparty/vllmareal/engine/vllm_ext (align with engine structure)

New additions:

  • .claude/commands/create-pr.md - Automated PR creation workflow documentation
  • .claude/agents/launcher-scheduler-expert.md - Agent documentation updates
  • .claude/plans/wobbly-kindling-quill.md - Planning artifact

Impact:

  • 135 files updated with import path changes
  • No functional changes to any modules
  • All existing tests should pass without modification

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @garrett4wade, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the codebase by centralizing core infrastructure components into a dedicated areal/infra module. The primary goal is to enhance code organization and clearly delineate the architectural separation between core infrastructure, engine implementations, and workflow definitions. This restructuring involves relocating several modules and updating a large number of import paths, all without altering any existing functionality.

Highlights

  • Core Infrastructure Consolidation: The core infrastructure components have been unified under a new areal/infra module, improving overall code organization and clarifying architectural boundaries.
  • Module Relocation: Key components such as RolloutController and TrainController have been moved to areal/infra/controller/, and platform abstractions from areal/platforms/ are now located in areal/infra/platforms/.
  • vLLM Extension Migration: vLLM-specific extensions have been migrated from areal/thirdparty/vllm/ to areal/engine/vllm_ext/.
  • Extensive Import Updates: All import statements across 131 files have been updated to reflect the new module structure, ensuring consistency throughout the codebase.
  • Pure Refactoring: This pull request is a pure refactoring effort, introducing no functional changes and is expected to maintain existing test pass rates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a large-scale refactoring to consolidate core infrastructure components under a new areal/infra module. The changes primarily involve moving files and updating import paths across the codebase, which improves code organization and clarifies architectural boundaries.

My review found one critical issue: a missing import in areal/infra/__init__.py that would cause an ImportError. I've also pointed out that some documentation in AGENTS.md is now outdated due to this refactoring and should be updated to reflect the new module structure.

Apart from these points, the refactoring appears to be well-executed, and the new structure is a good improvement.

Comment thread areal/infra/__init__.py
Comment thread AGENTS.md
@garrett4wade garrett4wade added the safe-to-test Ready to run unit-tests in a PR. label Feb 2, 2026
@garrett4wade garrett4wade changed the title refactor(infra): consolidate core infrastructure under areal/infra chore(infra): consolidate infrastructure and add create-pr command Feb 2, 2026
@garrett4wade garrett4wade added safe-to-test Ready to run unit-tests in a PR. and removed safe-to-test Ready to run unit-tests in a PR. labels Feb 2, 2026

@rchardx rchardx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.claude/agents/launcher-scheduler-expert.md:98
The file references areal.platforms.current_platform which should be updated to areal.infra.platforms.current_platform for consistency with the PR's import migration.

Comment thread .claude/commands/create-pr.md Outdated
Consolidate scattered infrastructure modules into a unified `areal/infra` package for better organization and discoverability.

Key changes:
- Rename `areal/core` → `areal/infra` to better reflect infrastructure role
- Move `areal/controller` → `areal/infra/controller` for logical grouping
- Move `areal/platforms` → `areal/infra/platforms` to colocate platform abstractions
- Move vLLM extensions from `areal/thirdparty/vllm` → `areal/engine/vllm_ext` to align with other engine extensions
- Add `.claude/commands/create-pr.md` for automated PR creation workflow
- Add launcher-scheduler expert agent documentation
- Update all imports across 135 files to reflect new structure
@rchardx rchardx merged commit a0ec9ce into main Feb 2, 2026
1 check passed
@rchardx rchardx deleted the fw/doc branch February 2, 2026 13:17
@rchardx rchardx mentioned this pull request Feb 24, 2026
16 tasks
leandermaben pushed a commit to leandermaben/AReaL that referenced this pull request Mar 24, 2026
…real-project#875)

Consolidate scattered infrastructure modules into a unified `areal/infra` package for better organization and discoverability.

Key changes:
- Rename `areal/core` → `areal/infra` to better reflect infrastructure role
- Move `areal/controller` → `areal/infra/controller` for logical grouping
- Move `areal/platforms` → `areal/infra/platforms` to colocate platform abstractions
- Move vLLM extensions from `areal/thirdparty/vllm` → `areal/engine/vllm_ext` to align with other engine extensions
- Add `.claude/commands/create-pr.md` for automated PR creation workflow
- Add launcher-scheduler expert agent documentation
- Update all imports across 135 files to reflect new structure
SathyaGnanakumar pushed a commit to danielkiely/AReaL that referenced this pull request Apr 29, 2026
…real-project#875)

Consolidate scattered infrastructure modules into a unified `areal/infra` package for better organization and discoverability.

Key changes:
- Rename `areal/core` → `areal/infra` to better reflect infrastructure role
- Move `areal/controller` → `areal/infra/controller` for logical grouping
- Move `areal/platforms` → `areal/infra/platforms` to colocate platform abstractions
- Move vLLM extensions from `areal/thirdparty/vllm` → `areal/engine/vllm_ext` to align with other engine extensions
- Add `.claude/commands/create-pr.md` for automated PR creation workflow
- Add launcher-scheduler expert agent documentation
- Update all imports across 135 files to reflect new structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe-to-test Ready to run unit-tests in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants