Conversation
Summary of ChangesHello @garrett4wade, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the codebase by centralizing core infrastructure components into a dedicated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a large-scale refactoring to consolidate core infrastructure components under a new areal/infra module. The changes primarily involve moving files and updating import paths across the codebase, which improves code organization and clarifies architectural boundaries.
My review found one critical issue: a missing import in areal/infra/__init__.py that would cause an ImportError. I've also pointed out that some documentation in AGENTS.md is now outdated due to this refactoring and should be updated to reflect the new module structure.
Apart from these points, the refactoring appears to be well-executed, and the new structure is a good improvement.
rchardx
left a comment
There was a problem hiding this comment.
.claude/agents/launcher-scheduler-expert.md:98
The file references areal.platforms.current_platform which should be updated to areal.infra.platforms.current_platform for consistency with the PR's import migration.
Consolidate scattered infrastructure modules into a unified `areal/infra` package for better organization and discoverability. Key changes: - Rename `areal/core` → `areal/infra` to better reflect infrastructure role - Move `areal/controller` → `areal/infra/controller` for logical grouping - Move `areal/platforms` → `areal/infra/platforms` to colocate platform abstractions - Move vLLM extensions from `areal/thirdparty/vllm` → `areal/engine/vllm_ext` to align with other engine extensions - Add `.claude/commands/create-pr.md` for automated PR creation workflow - Add launcher-scheduler expert agent documentation - Update all imports across 135 files to reflect new structure
…real-project#875) Consolidate scattered infrastructure modules into a unified `areal/infra` package for better organization and discoverability. Key changes: - Rename `areal/core` → `areal/infra` to better reflect infrastructure role - Move `areal/controller` → `areal/infra/controller` for logical grouping - Move `areal/platforms` → `areal/infra/platforms` to colocate platform abstractions - Move vLLM extensions from `areal/thirdparty/vllm` → `areal/engine/vllm_ext` to align with other engine extensions - Add `.claude/commands/create-pr.md` for automated PR creation workflow - Add launcher-scheduler expert agent documentation - Update all imports across 135 files to reflect new structure
…real-project#875) Consolidate scattered infrastructure modules into a unified `areal/infra` package for better organization and discoverability. Key changes: - Rename `areal/core` → `areal/infra` to better reflect infrastructure role - Move `areal/controller` → `areal/infra/controller` for logical grouping - Move `areal/platforms` → `areal/infra/platforms` to colocate platform abstractions - Move vLLM extensions from `areal/thirdparty/vllm` → `areal/engine/vllm_ext` to align with other engine extensions - Add `.claude/commands/create-pr.md` for automated PR creation workflow - Add launcher-scheduler expert agent documentation - Update all imports across 135 files to reflect new structure
Description
Consolidate scattered infrastructure modules into a unified
areal/infrapackage for better code organization and discoverability. This refactoring groups related infrastructure components together without changing functionality.Related Issue
N/A (Internal refactoring)
Type of Change
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
N/A
Additional Context
Infrastructure consolidation:
areal/core→areal/infra(better reflects purpose)areal/controller→areal/infra/controller(logical grouping)areal/platforms→areal/infra/platforms(colocate platform abstractions)areal/thirdparty/vllm→areal/engine/vllm_ext(align with engine structure)New additions:
.claude/commands/create-pr.md- Automated PR creation workflow documentation.claude/agents/launcher-scheduler-expert.md- Agent documentation updates.claude/plans/wobbly-kindling-quill.md- Planning artifactImpact: