chore: add Claude Code configuration for AReaL#866
Conversation
Summary of ChangesHello @rchardx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AReaL codebase by integrating a comprehensive Claude Code setup. The changes aim to automate and streamline various development processes, from code review and commit message generation to providing expert guidance on complex topics like distributed training and algorithm implementation. By introducing specialized AI agents, commands, rules, and skills, the PR seeks to improve code quality, accelerate development cycles, and provide robust support for engineers working on the project. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
b13ff63 to
4a4b15b
Compare
There was a problem hiding this comment.
Code Review
This pull request sets up a comprehensive configuration for Claude Code, including specialized agents, commands, rules, and skills tailored for the AReaL codebase. The changes are extensive and well-structured, primarily involving the addition of markdown and configuration files. I've identified a few minor formatting issues in the markdown files that could improve clarity and one potential area for improvement in the agent selection logic to make it more precise. Overall, this is a great addition that will significantly enhance the development workflow.
There was a problem hiding this comment.
Pull request overview
Adds a repository-scoped Claude Code setup for AReaL, including shared agents/commands/rules/skills and updated project guidance.
Changes:
- Add
.claude/configuration: specialized agents, reusable commands, rule packs, skills, and PR-review reference data. - Update
CLAUDE.mdto document project structure, workflows, and common developer commands. - Update
.gitignoreto keep Claude local/session artifacts untracked while committing shared Claude config.
Reviewed changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
CLAUDE.md |
New project overview + Claude usage guidance. |
.gitignore |
Stops ignoring all of .claude/; ignores local settings + sessions only. |
.claude/settings.json |
Enables a PostToolUse hook for reminding agent updates. |
.claude/hooks/check-expert-update.sh |
Hook script that maps edited paths to “expert agent” reminders. |
.claude/rules/testing.md |
Claude “testing rules” guidance scoped to test paths. |
.claude/rules/distributed.md |
Claude “distributed code rules” guidance scoped to engine/experimental/fsdp paths. |
.claude/rules/code-style.md |
Claude “code style rules” guidance (global). |
.claude/rules/api-config.md |
Claude “API/config rules” guidance scoped to areal/api/**. |
.claude/data/pr-review-templates.md |
Template library used by /pr-review. |
.claude/data/pr-review-change-types.md |
Change-type detection reference used by /pr-review. |
.claude/commands/pr-review.md |
Defines /pr-review command workflow and output format. |
.claude/commands/gen-commit-msg.md |
Defines /gen-commit-msg command workflow and output format. |
.claude/agents/simple-code-reviewer.md |
Adds a lightweight reviewer agent configuration. |
.claude/agents/planner.md |
Adds an implementation planning agent configuration. |
.claude/agents/megatron-expert.md |
Adds a Megatron/Pipeline Parallel expert agent configuration. |
.claude/agents/fsdp-expert.md |
Adds an FSDP/DTensor expert agent configuration. |
.claude/agents/code-verifier.md |
Adds a “run checks/tests” verifier agent configuration. |
.claude/agents/archon-expert.md |
Adds an Archon/MoE expert agent configuration. |
.claude/agents/algorithm-expert.md |
Adds an RL algorithm expert agent configuration. |
.claude/skills/debug-distributed/SKILL.md |
Adds a distributed debugging playbook skill. |
.claude/skills/add-workflow/SKILL.md |
Adds a “how to add a workflow” skill template. |
.claude/skills/add-reward/SKILL.md |
Adds a “how to add a reward” skill template. |
.claude/skills/add-dataset/SKILL.md |
Adds a “how to add a dataset” skill template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4a4b15b to
1a57732
Compare
Set up comprehensive Claude Code integration with domain-specific agents, commands, rules, and skills for the codebase. Key changes: - Add 7 specialized agents (algorithm, FSDP, Megatron, Archon experts) - Add /pr-review and /gen-commit-msg commands - Add rules for code style, API config, distributed, and testing - Add skills for adding datasets, rewards, workflows, and debugging - Update CLAUDE.md with project overview and guidelines - Configure settings.json with project-specific permissions
1a57732 to
b0c93fc
Compare
Set up comprehensive Claude Code integration with domain-specific agents, commands, rules, and skills for the codebase. Key changes: - Add 7 specialized agents (algorithm, FSDP, Megatron, Archon experts) - Add /pr-review and /gen-commit-msg commands - Add rules for code style, API config, distributed, and testing - Add skills for adding datasets, rewards, workflows, and debugging - Update CLAUDE.md with project overview and guidelines - Configure settings.json with project-specific permissions
Set up comprehensive Claude Code integration with domain-specific agents, commands, rules, and skills for the codebase. Key changes: - Add 7 specialized agents (algorithm, FSDP, Megatron, Archon experts) - Add /pr-review and /gen-commit-msg commands - Add rules for code style, API config, distributed, and testing - Add skills for adding datasets, rewards, workflows, and debugging - Update CLAUDE.md with project overview and guidelines - Configure settings.json with project-specific permissions
Description
Set up comprehensive Claude Code integration with domain-specific agents, commands, rules, and skills for the codebase.
Key changes:
Type of Change
work as expected)
Checklist
jb build docs/gemini review)