Skip to content

Fix the loop exit condition in the agenerator #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrett4wade merged 6 commits into from
Jan 27, 2026
Merged

Fix the loop exit condition in the agenerator #858

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a59005
test: add unit tests for abort loop condition fix in RemoteInfEngine
yulangz Jan 27, 2026
658b629
refactor: use real RemoteInfEngine with mocked arequest_with_retry
yulangz Jan 27, 2026
e4bf4e0
fix code and ut
yulangz Jan 27, 2026
5e8dfe3
format
yulangz Jan 27, 2026
8052d22
update doc
yulangz Jan 27, 2026
2502b06
remove ut
yulangz Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion areal/core/remote_inf_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,9 +739,10 @@ async def agenerate(self, req: ModelRequest) -> ModelResponse:

# Deal with rollout interruption
stop_reason = None
ori_max_new_tokens = gconfig.max_new_tokens
Comment thread
garrett4wade marked this conversation as resolved.
while (
stop_reason not in ["stop", "tool_calls", "length"]
and len(accumulated_output_tokens) < gconfig.max_new_tokens
and len(accumulated_output_tokens) < ori_max_new_tokens
Comment thread
garrett4wade marked this conversation as resolved.
):
# Request is interrupted, wait for some time to avoid interfering
# with update weights requests
Expand Down