Bump v0.5.2#855
Conversation
Summary of ChangesHello @garrett4wade, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates all version references across the AReaL project to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly bumps the project version from v0.5.1 to v0.5.2 across the codebase, including the main version file, documentation, and example configurations. The changes are consistent and reflect the new version. However, I've noticed that the version string is hardcoded in multiple locations. This practice can make future version updates tedious and error-prone. To improve maintainability, I recommend exploring ways to centralize the version string. For instance, documentation could use placeholders (e.g., v{{ version }}) that are substituted during a build process, and configuration files could potentially use environment variables for the image tag. This would streamline future releases.
| | Docker | 27.5.1 | | ||
| | NVIDIA Container Toolkit | See [installation guide](https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html) | | ||
| | AReaL Image | `ghcr.io/inclusionai/areal-runtime:v0.5.1` (includes runtime dependencies and Ray components) | | ||
| | AReaL Image | `ghcr.io/inclusionai/areal-runtime:v0.5.2` (includes runtime dependencies and Ray components) | |
There was a problem hiding this comment.
While this update is correct, hardcoding the version string in multiple places across documentation and example files makes the project harder to maintain. Each version bump requires manually finding and replacing all occurrences, which is error-prone. As suggested in the general feedback, centralizing this version string would be a significant improvement for future releases.
| memory: 32GB+ | ||
| disk_size: 256GB | ||
| image_id: docker:ghcr.io/inclusionai/areal-runtime:v0.5.1 | ||
| image_id: docker:ghcr.io/inclusionai/areal-runtime:v0.5.2 |
No description provided.