[BugFix] VLM RLVR add reward func#851
Conversation
Summary of ChangesHello @PopSoda2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug by enhancing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for dynamically loading a reward function from a string path in VisionRLVRWorkflow, making it consistent with the parent RLVRWorkflow. The change is functionally correct and fixes a bug where using a string path for reward_fn would previously lead to an AttributeError. My review includes one suggestion to improve code style and maintainability by moving local imports to the top of the file, which also aligns the implementation more closely with existing patterns in the codebase.
This pull request adds support for dynamically loading a reward function from a string path in `VisionRLVRWorkflow`, making it consistent with the parent `RLVRWorkflow`. The change is functionally correct and fixes a bug where using a string path for `reward_fn` would previously lead to an `AttributeError`.
This pull request adds support for dynamically loading a reward function from a string path in `VisionRLVRWorkflow`, making it consistent with the parent `RLVRWorkflow`. The change is functionally correct and fixes a bug where using a string path for `reward_fn` would previously lead to an `AttributeError`.
Description
Add a
async_reward_fnsimilar with RLVR workflow:Related Issue
Fixes #(issue)
#850
Type of Change
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
Additional Context
Need help? Check the Contributing Guide or ask in
GitHub Discussions!