Skip to content

fix: remove duplicate setup in gsm8k_rl#842

Merged
garrett4wade merged 1 commit into
areal-project:mainfrom
v3nividiv1ci:fix/gsm8k-rl-dup
Jan 21, 2026
Merged

fix: remove duplicate setup in gsm8k_rl#842
garrett4wade merged 1 commit into
areal-project:mainfrom
v3nividiv1ci:fix/gsm8k-rl-dup

Conversation

@v3nividiv1ci

@v3nividiv1ci v3nividiv1ci commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Description

This PR removes duplicated valid_dataset loading and duplicated workflow_kwargs / eval_workflow_kwargs construction in examples/math/gsm8k_rl.py. As a commonly referenced entry-point for code walkthroughs, keeping this example clean improves readability and consistency (aligned with gsm8k_sft.py). The duplicated blocks were redundant because later definitions overwrote earlier ones, so this is no functional change.

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not
    work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

Checklist

  • I have read the Contributing Guide
  • I have run formatting tools (pre-commit or manual)
  • I have run relevant unit tests and they pass
  • I have added tests for new functionality
  • I have updated documentation if needed
  • My branch is up to date with main
  • This PR introduces breaking changes (if yes, fill out details below)
  • If this PR changes documentation, I have built and previewed it locally with
    jb build docs
  • No critical issues raised by AI reviewers (/gemini review)

Breaking Change Details (if applicable):

N/A

Additional Context

N/A


Need help? Check the Contributing Guide or ask in
GitHub Discussions!

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @v3nividiv1ci, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the maintainability and clarity of the gsm8k_rl.py example by removing redundant code blocks. The changes specifically target duplicated dataset loading and workflow argument constructions, ensuring that the example remains clean and consistent without altering its behavior.

Highlights

  • Redundant Code Removal: Eliminated duplicate loading of valid_dataset and redundant construction of workflow_kwargs and eval_workflow_kwargs in examples/math/gsm8k_rl.py.
  • Code Readability and Consistency: Improved the readability and consistency of the gsm8k_rl.py example by removing dead code, aligning it with gsm8k_sft.py.
  • No Functional Change: This refactoring introduces no functional changes, as the removed definitions were previously overwritten by later code.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors examples/math/gsm8k_rl.py to remove duplicated code. Specifically, it removes redundant definitions of valid_dataset, workflow_kwargs, and eval_workflow_kwargs. The remaining calls to get_custom_dataset are updated to use keyword arguments, which improves readability. The changes are correct and improve the clarity and maintainability of the example script. This is a good cleanup with no functional changes, as described.

@garrett4wade garrett4wade left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrett4wade garrett4wade merged commit 1750982 into areal-project:main Jan 21, 2026
1 check passed
leandermaben pushed a commit to leandermaben/AReaL that referenced this pull request Mar 24, 2026
SathyaGnanakumar pushed a commit to danielkiely/AReaL that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants