Use github pagination to allow using older versions #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add pagination logic when checking for versions This prevents older versions from no longer being considered installable if they are on page2+ of the github releases API.
* Ran prettier
* Run prettier 1.18.2 Run specific version of prettier as newer versions will output different results which do not pass the build.
|
hello @rsora , can you take a look at merging this? if merged, we could drop our fork of the repo |
Contributor
|
on it 😸 |
rsora
approved these changes
Nov 16, 2020
Contributor
rsora
left a comment
rsora
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for contributing!
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A project I work on uses protoc 3.6.1, which just rolled over to page 2 in the releases API, and can no longer be setup using this action.
The error we see is:
##[error]unable to get latest versionCurrently, this action calls https://api.github.com/repos/protocolbuffers/protobuf/releases to get all possible versions, but some releases have now rolled over to the 2nd page (and will eventually go on to the 3rd, etc etc).
As you can see, 3.6.1 as of today is now on the top of the second page - https://api.github.com/repos/protocolbuffers/protobuf/releases?page=2
This PR changes the
fetchVersionslogic to loop through the release pages until we reach the end, allowing all old versions to be used.I've also updated the tests
nockAPI mocks to return the current 1st, 2nd and 3rd pages of results from the protobuf releases API calls.