Fix quit ok message not sent
#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
topic: code
umbynos
approved these changes
Nov 26, 2021
Contributor
umbynos
left a comment
umbynos
left a comment
There was a problem hiding this comment.
Remember to update the dependency also in the licenses
silvanocerza
force-pushed
the
scerza/fix-quit-message-bug
branch
from
b1dfe34 to
2094254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of
github.com/arduino/pluggable-discovery-protocol-handlerhad an issue that prevented the ok message to be sent when calling thequitcommand.The new version fixed that issue.