Fixed a compatibility issue with the 0.11.0 CLI.
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made sure the `basename` of the temp folder matches with the name of the sketch file. Closes #27 Signed-off-by: Akos Kitta <[email protected]>
rsora
approved these changes
Jun 30, 2020
cmaglie
approved these changes
Jun 30, 2020
kittaakos
pushed a commit
that referenced
this pull request
Jul 23, 2020
#28 has fixed the location of the `ino` file but the generated `cpp` and `compile_flags.txt` were not moved into the sketch folder. Touching the `ino` file triggered a `'textDocument/didChange'` event, but the `updateFileData` call failed as the files were not found. This commit moves the files into the appropriate location. Signed-off-by: Akos Kitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made sure the
basenameof the temp folder matches with the name of thesketch file.
Closes #27
Signed-off-by: Akos Kitta [email protected]