fix: execute the Arduino CLI without a shell

arduino-ide-extension/src/node/arduino-daemon-impl.ts

@@ -10,7 +10,6 @@ import {
 } from '@theia/core/lib/common/disposable';
 import { Event, Emitter } from '@theia/core/lib/common/event';
 import { deepClone } from '@theia/core/lib/common/objects';
-import { environment } from '@theia/application-package/lib/environment';
 import { EnvVariablesServer } from '@theia/core/lib/common/env-variables';
 import { BackendApplicationContribution } from '@theia/core/lib/node/backend-application';
 import { ArduinoDaemon, NotificationServiceServer } from '../common/protocol';
@@ -71,22 +70,6 @@ export class ArduinoDaemonImpl
       const cliPath = this.getExecPath();
       this.onData(`Starting daemon from ${cliPath}...`);
       const { daemon, port } = await this.spawnDaemonProcess();
-      // Watchdog process for terminating the daemon process when the backend app terminates.
-      spawn(
-        process.execPath,
-        [
-          join(__dirname, 'daemon-watcher.js'),
-          String(process.pid),
-          String(daemon.pid),
-        ],
-        {
-          env: environment.electron.runAsNodeEnv(),
-          detached: true,
-          stdio: 'ignore',
-          windowsHide: true,
-        }
-      ).unref();
-
       this.toDispose.pushAll([
         Disposable.create(() => {
           if (daemon.pid) {
@@ -173,10 +156,9 @@ export class ArduinoDaemonImpl
     const cliPath = this.getExecPath();
     const ready = new Deferred<{ daemon: ChildProcess; port: string }>();
     const options = {
-      shell: true,
       env: { ...deepClone(process.env), NO_COLOR: String(true) },
     };
-    const daemon = spawn(`"${cliPath}"`, args, options);
+    const daemon = spawn(cliPath, args, options);
 
     // If the process exists right after the daemon gRPC server has started (due to an invalid port, unknown address, TCP port in use, etc.)
     // we have no idea about the root cause unless we sniff into the first data package and dispatch the logic on that. Note, we get a exit code 1.