Prevent layout shift on hover in libs/board manager #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescospissu
added
type: enhancement
3 tasks
AlbyIanna
suggested changes
Oct 24, 2022
| if (!this.state.versionUpdate) this.setState({ focus: false }); | ||
| }} | ||
| > | ||
| <div> |
There was a problem hiding this comment.
Having a div here is superfluous at this point. Please replace it with a react fragment (<>...</>).
There was a problem hiding this comment.
I replaced it here. Thanks 👍
There was a problem hiding this comment.
even the fragment is superfluous we can just return the node no?
return itemRenderer.renderItem(
Object.assign(this.state, { item }),
this.install.bind(this),
this.uninstall.bind(this),
this.onVersionChange.bind(this)
);
91volt
approved these changes
Oct 24, 2022
AlbyIanna
approved these changes
Oct 24, 2022
This was referenced Oct 26, 2022
Closed
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At present in the IDE2 when hovering over an item in the library or board manager the item height changes, shifting the position of all library items in the manager. We should avoid this behavior because it is not ideal and could be considered "inaccessible."
Change description
Retain the version drop-down and the install button always visible in the item.
Other information
Reviewer checklist