Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation for "Save" #2213

Open
3 tasks done
Sinclair-ZX81 opened this issue Sep 3, 2023 · 5 comments
Open
3 tasks done

Missing translation for "Save" #2213

Sinclair-ZX81 opened this issue Sep 3, 2023 · 5 comments
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@Sinclair-ZX81
Copy link

Sinclair-ZX81 commented Sep 3, 2023

Describe the problem

Arduino IDE 2.2.1:
(also tested with 2.2.2-nightly-20230903)

grafik

To reproduce

Just open the IDE Files menu

Expected behavior

The German word for Save is Speichern

Arduino IDE version

2.2.1

Operating system

Windows

Operating system version

Windows 10 x64

Additional context

Related: #2215

Additional reports

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@Sinclair-ZX81 Sinclair-ZX81 added the type: imperfection Perceived defect in any part of project label Sep 3, 2023
@Sinclair-ZX81 Sinclair-ZX81 changed the title Missing translation for "save" in German Missing translation for "Save" in German Sep 3, 2023
@per1234
Copy link
Contributor

per1234 commented Sep 3, 2023

Thanks for reporting this @Sinclair-ZX81.

I confirm that there was a regression in the localization of the File > Save menu item. I bisected the regression to 192aac5, where the language packs were bumped from 1.53.2 to 1.70.0.

The localization data key for the menu item is set here:

label: nls.localize('vscode/fileCommands/save', 'Save'),

The data is here in version 1.53.2 of the language pack:

https://github.com/microsoft/vscode-loc/blob/295dfb35491adc41df4b89e0d839086131a34257/i18n/vscode-language-pack-de/translations/main.i18n.json#L5000

		"vs/workbench/contrib/files/browser/fileCommands": {
			"saveAs": "Speichern unter...",
			"save": "Speichern",

Without explanation of the reason for the breaking change, the data was moved in the language packs from vs/workbench/contrib/files/browser/fileCommands/save to vs/workbench/contrib/files/browser/fileConstants/save by microsoft/vscode-loc@e36740c:

https://github.com/microsoft/vscode-loc/blob/a51eba0bb6e14e9b26cb7b5fed1aeca520552010/i18n/vscode-language-pack-de/translations/main.i18n.json#L6189

		"vs/workbench/contrib/files/browser/fileCommands": {
			"discard": "Verwerfen",
			"genericRevertError": "Fehler beim Zurücksetzen von '{0}': {1}",
			"genericSaveError": "Fehler beim Speichern von \"{0}\": {1}",
			"modifiedLabel": "{0} (in Datei) ↔ {1}",
			"retry": "Wiederholen"
		},
		"vs/workbench/contrib/files/browser/fileConstants": {
			"newUntitledFile": "Neue unbenannte Datei",
			"removeFolderFromWorkspace": "Ordner aus dem Arbeitsbereich entfernen",
			"save": "Speichern",

And the key is also updated to vs/workbench/contrib/files/browser/fileConstants/save in the Theia package:

https://github.com/eclipse-theia/theia/blob/v1.39.0/packages/core/src/common/i18n/nls.metadata.json#L9130-L9132

		"vs/workbench/contrib/files/browser/fileConstants": [
			"saveAs",
			"save",

@per1234 per1234 added the topic: code Related to content of the project itself label Sep 3, 2023
@DanielFrantes

This comment was marked as outdated.

@DanielFrantes

This comment was marked as duplicate.

@Sinclair-ZX81

This comment was marked as outdated.

@per1234 per1234 changed the title Missing translation for "Save" in German Missing translation for "Save" Sep 14, 2023
@ralf-krause

This comment was marked as duplicate.

@arduino arduino locked as too heated and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants