Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Cloud "Login entry point" to the sidebar of IDE2 #1877

Closed
3 tasks done
davegarthsimpson opened this issue Feb 10, 2023 · 3 comments · Fixed by #1881
Closed
3 tasks done

Move Cloud "Login entry point" to the sidebar of IDE2 #1877

davegarthsimpson opened this issue Feb 10, 2023 · 3 comments · Fixed by #1881
Assignees
Labels
conclusion: resolved Issue was resolved topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@davegarthsimpson
Copy link
Contributor

Describe the request

We hope to introduce and promote Arduino Cloud to as many IDE2 users as possible. We would therefore like to make the integrated cloud login in IDE2 more visible.

Outcome

A user avatar together with a popover menu should be added to the "first level of the interface", in the sidebar. The popover menu should contain Arduino cloud related actions, namely Sign in/out and links to the cloud platform.

The existing avatar should be removed, and the "Cloud account state element" (at the bottom of the cloud sketchbook list) should be augmented as per design spec.

Additional context

Figma links here

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@davegarthsimpson davegarthsimpson added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Feb 10, 2023
@kittaakos
Copy link
Contributor

The new requested login entry point occupies the space from the default Account management in Theia/VS Code.

From VS Code:

Screen Shot 2023-02-10 at 14 57 24

It will likely break the IDE2 UI if any future VS Code extension contributing to authentication API is added to IDE2. See the Theia logic here. Currently, no extensions contribute to this API, so there is no UI issue now.

@kittaakos
Copy link
Contributor

When Advanced > Show/Hide Remote Sketchbook is off ("arduino.cloud.enabled": false), then IDE2 does not show File > New Remote Sketch, and the Remote Sketchbook is also hidden from the Sketchbook view.

Screen Shot 2023-02-10 at 15 07 17

Screen Shot 2023-02-10 at 15 07 23

@91volt, does IDE2 want to hide the login entry point from the sidebar? Thank you!

@davegarthsimpson
Copy link
Contributor Author

davegarthsimpson commented Feb 10, 2023

The new requested login entry point occupies the space from the default Account management in Theia/VS Code.

It will likely break the IDE2 UI if any future VS Code extension contributing to authentication API is added to IDE2. See the Theia logic here. Currently, no extensions contribute to this API, so there is no UI issue now.

good point, @91volt if in the future we add something that contributes to the authentication api we may need to consider moving the cloud avatar to avoid obscuring the default Theia/VS Code element.

kittaakos pushed a commit that referenced this issue Feb 10, 2023
@per1234 per1234 linked a pull request Feb 11, 2023 that will close this issue
4 tasks
kittaakos pushed a commit that referenced this issue Feb 13, 2023
kittaakos pushed a commit that referenced this issue Feb 15, 2023
kittaakos pushed a commit that referenced this issue Feb 20, 2023
@kittaakos kittaakos added the conclusion: resolved Issue was resolved label Feb 22, 2023
@per1234 per1234 added the topic: cloud Related to Arduino Cloud and cloud sketches label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants