feat: support user partition preservation #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you please fix conflicts and provide a test build? |
Xayton
approved these changes
Dec 11, 2025
Contributor
Xayton
left a comment
Xayton
left a comment
There was a problem hiding this comment.
I have tested it, and user's data was preserved correctly.
| return nil | ||
| } | ||
|
|
||
| func checkBoardGPTTable(ctx context.Context, qdlPath, flashDir *paths.Path) error { |
Contributor
There was a problem hiding this comment.
I'm not a fan of a method returning it's output (or string message) just by returning an error. But this can be fine.
At least, add a small comment to the function, explaining why we are checking the GPT and why this is the way we use to know if the board supports preserving user's data or not.
Suggested change
| func checkBoardGPTTable(ctx context.Context, qdlPath, flashDir *paths.Path) error { | |
| // Checks the board GPT table and counts the number of partitions, this tells if the board supports preserving or not user's data. | |
| func checkBoardGPTTable(ctx context.Context, qdlPath, flashDir *paths.Path) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a flag to the
flashcommand to allow the user to preserve thehomepartitionChange description
Add a flag to the
flashcommand to allow the user to preserve thehomepartition. The flasher will check if both the image currently on the board and the one to be flasher support user partition preservation (so they are not a R0 image).Additional Notes
Reviewer checklist
main.