Skip to content

feat: check for tool updates when printing current version #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: check for tool updates when printing current version #25

wants to merge 4 commits into from

Conversation

@MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Nov 4, 2025 •
edited
Loading

Motivation

Users should know if a new version of the tool is available.

Change description

A message is printed if a new version of the tool is available when checking the current version:

$ ./build/arduino-flasher-cli version
Arduino Flasher CLI 0.0.0-d6bef23


A new release of Arduino Flasher CLI is available: 0.0.0-d6bef23 → 0.3.0
https://github.com/arduino/arduino-flasher-cli/releases/latest

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@MatteoPologruto MatteoPologruto self-assigned this Nov 4, 2025
@MatteoPologruto MatteoPologruto added the enhancement New feature or request label Nov 4, 2025
@MatteoPologruto MatteoPologruto marked this pull request as ready for review November 4, 2025 16:57
@MatteoPologruto MatteoPologruto linked an issue Nov 4, 2025 that may be closed by this pull request
Check if a new version of the arduino-flasher-cli is available #19
Open
@MatteoPologruto MatteoPologruto requested a review from a team November 4, 2025 16:57
per1234
per1234 reviewed Nov 5, 2025
View reviewed changes
dido18
dido18 reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@dido18 dido18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would display a notification about a new version being available before every command, not only when running the version command.

The update check should be non-blocking — if an error occurs during the check, a general warning should be shown without preventing the command from running.

@MatteoPologruto @per1234
Update check_for_updates.go
1899741 
Co-authored-by: Per Tillisch <[email protected]>
lucarin91
lucarin91 reviewed Nov 6, 2025
View reviewed changes
main.go
Comment on lines +64 to +67
err := checkForUpdates()
if err != nil {
feedback.Warning("failed to check for updates: " + err.Error())
}
Copy link
Contributor

@lucarin91 lucarin91 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should check updates also in other commands, although we could start with this for now.

.licenses/arduino-flasher-cli/go/github.com/arduino/go-paths-helper.dep.yml
Copy link
Contributor

@lucarin91 lucarin91 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do those files become executable? Can you revert this change?

Copy link
Contributor Author

@MatteoPologruto MatteoPologruto Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I downloaded the artifact generated by the check-licenses workflow and committed the changes

Copy link
Contributor

@lucarin91 lucarin91 Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably Windows or WSL. Can you chmod everything in .licenses to 644 again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucarin91 lucarin91 lucarin91 left review comments

@per1234 per1234 per1234 left review comments

@dido18 dido18 dido18 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@MatteoPologruto MatteoPologruto

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check if a new version of the arduino-flasher-cli is available

4 participants

@MatteoPologruto @lucarin91 @per1234 @dido18