Add OPAMP library for Uno R4 (WiFi, Minima) #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
per1234
added
type: enhancement
per1234
previously requested changes
Aug 12, 2023
Multiple naming and code formatting changes. Co-authored-by: per1234 <[email protected]>
per1234
dismissed
their stale review
Requested changes have been made. Thanks!
|
The PNG images in this PR can be compressed by 66% (-171KB) without visible quality degradation.
Tool used: https://tinypng.com/, alternative: https://compresspng.com/ |
|
.. addressed in maxgerhardt@c84a823. |
|
Memory usage change @ c84a823
Click for full report table
Click for full report CSV |
aentinger
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Good work @maxgerhardt ☕ 👋 We are mostly there, a couple of changes and I see this as good to merge.
aentinger
requested changes
Sep 6, 2023
There was a problem hiding this comment.
I feel we are approaching the finish line, @maxgerhardt please resolve the final comments, I'll give it another look-over and then I believe we can merge.
aentinger
reviewed
Sep 14, 2023
aentinger
reviewed
Sep 14, 2023
aentinger
reviewed
Sep 14, 2023
aentinger
reviewed
Sep 14, 2023
aentinger
reviewed
Sep 14, 2023
aentinger
reviewed
Sep 14, 2023
aentinger
reviewed
Sep 14, 2023
aentinger
reviewed
Sep 14, 2023
aentinger
requested changes
Sep 14, 2023
Add more const correctness Co-authored-by: Alexander Entinger <[email protected]>
aentinger
approved these changes
Sep 15, 2023
Closed
pennam
pushed a commit
to pennam/ArduinoCore-renesas
that referenced
this pull request
Jan 5, 2024
[AE-96] Add RTC NTP Sync Example
cristidragomir97
pushed a commit
to cristidragomir97/ArduinoCore-renesas
that referenced
this pull request
May 20, 2024
[AE-96] Add RTC NTP Sync Example Former-commit-id: dcd5e7f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23
Adds an OPAMP library for the Arduino Uno R4 WiFi and Minima boards. Portenta C33's chip does not have an OPAMP.
Does not rely on Renesas FSP code, writes to OPAMP registers directly, to save codesize.
Only supports starting the OPAMP, none of the fancier modes for AGC links / trigger inputs / start ADCs. Very simple.
Verified to be working on hardware using a MAX038-based function generator, Hantek 6022BL 2-channel oscilloscope and the basic "voltage follower" and "non-inverting amplifier" with gain 2 circuits. Output is channel 1 (yellow), input is channel 2 (green).