Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing return statement in SyncCanMsgRingbuffer::isFull() #368

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add missing return statement in SyncCanMsgRingbuffer::isFull() #368

merged 1 commit into from
Aug 21, 2024

Conversation

Wetmelon
Copy link
Contributor

@Wetmelon Wetmelon commented Aug 21, 2024 •
edited
Loading

Verbose compiler complaining about missing return statement in this const getter

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aentinger
aentinger approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you @Wetmelon 🚀 🙇 .

@aentinger aentinger merged commit 4606b85 into arduino:main Aug 21, 2024
7 checks passed
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wetmelon @CLAassistant @aentinger @per1234