Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Port mn Pin Function Select Register" in SVD file. #305

Merged
merged 1 commit into from
May 6, 2024

Conversation

embedded-kiddie
Copy link
Contributor

This fixes #276 and also incorrect definitions of Port1, Port2 and Port4.

Please refer to the repo https://github.com/embedded-kiddie/R7FA4M1AB .

Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the file you have to modify is svd/R7FA4M1AB.svd

@embedded-kiddie
Copy link
Contributor Author

embedded-kiddie commented May 6, 2024

Hi @umbynos ,

I think that the file you have to modify is svd/R7FA4M1AB.svd

I'm sorry I don't get your point.

What I did:

  1. Fork the repo ArduinoCore-renesas
  2. Create a clone by git clone on my local PC.
  3. Create a new branch named update-svd.
  4. Update svd/R7FA4M1AB.svd and commit it.
  5. Push the local repo to my remote origin.
  6. Create the PR from contribute button.

But it looks strange at the top right :スクリーンショット 0006-05-06 21 28 07

What went wrong?
Thanks.

Oh, the end of line code should be LF (Unix), not CR+LF (Windows) ?

I'm now checking...

Update "Port mn Pin Function Select Register" in SVD file.
@facchinm facchinm merged commit 141018d into arduino:main May 6, 2024
1 check passed
@facchinm
Copy link
Member

facchinm commented May 6, 2024

Merged, thank you so much!

@embedded-kiddie
Copy link
Contributor Author

@facchinm ,

I'm very sorry to bother you.
Thanks for merging.

@embedded-kiddie embedded-kiddie deleted the update-svd branch May 6, 2024 13:39
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unable to parse SVD file" error when starting debugger
4 participants