Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for flexible CAN baud rate #296

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Fix for flexible CAN baud rate #296

merged 2 commits into from
Apr 29, 2024

Conversation

fastbike
Copy link
Contributor

Fixes #295

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@facchinm facchinm requested a review from aentinger April 29, 2024 08:58
facchinm
facchinm approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to be squashed before merging

aentinger
aentinger approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aentinger aentinger merged commit 06bbfea into arduino:main Apr 29, 2024
6 of 7 checks passed
fastbike added a commit to fastbike/ArduinoCore-renesas that referenced this pull request Apr 29, 2024
@fastbike
Merge pull request #1 from arduino/main
c4c4d6f 
Fix for flexible CAN baud rate (arduino#296)
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Apr 29, 2024
@per1234 per1234 mentioned this pull request Apr 30, 2024
Closed
aentinger added a commit that referenced this pull request May 3, 2024
@aentinger
[Arduino_CAN] fix regression introduced in #296.
c59ae4c
aentinger added a commit that referenced this pull request May 3, 2024
@aentinger
[Arduino_CAN] fix regression introduced in #296. (#300)
78b63e9
@per1234 per1234 mentioned this pull request Jun 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm approved these changes

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow different CAN bit rates
5 participants
@fastbike @CLAassistant @aentinger @facchinm @per1234