Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthernetC33 debugging #223

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Dec 23, 2023

the missing volatile on bool dhcp_acquired in CNetIf.h caused problems for WiFi DHCP too. The waiting for DHCP ended only on timeout, but status() check then was OK because the IP address was set. So WiFi.begin just took long time.

I use Uno R4 to test Renesas Core LwIP networking. For WiFi I have an esp32 with the Hosted firmware on SPI and for Ethernet I replaced the EthernetDriver implementation with one over the W5500 driver (Ethernet 2 shied) from the esp8266 core. So I use Ethernet.begin methods with the MAC address parameter where some of this bugs appeared. The missing restartAsyncRequest(); in setMacAddress stopped the periodic task so DHCP then timed out. After that I had in EthernetDriver a buffer smaller than the DHCP packet and the code just hang. It was the the assert in CEth::output).

tested with LegacyEthernetTest

EthernetDriverW5500.cpp should work on Portenta C33 with MKR ETH shield too

@per1234 per1234 added the topic: code Related to content of the project itself label Dec 23, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aentinger
Copy link
Contributor

Looks like this branch is kept from merging by the license/cla check not bring signed. Can you sign the CLA agreement? Likely you've already signed it, but maybe you made this commit with a different email address? (This is a known cause for CLA errors).

@aentinger
Copy link
Contributor

Update: wasn't a CLA issue but a merge conflict with main. All is resolved now.

@JAndrassy JAndrassy force-pushed the ethernet_debugging branch 2 times, most recently from 75e25c7 to e9afdb0 Compare January 9, 2024 08:51
@aentinger
Copy link
Contributor

Why the force-push? Now there's another merge-conflict 😉 . You'd have needed to pull --rebase, then add a new commit on top (uncommenting the include). Do you want to clean this up or shall I?

@JAndrassy
Copy link
Contributor Author

JAndrassy commented Jan 9, 2024

sorry, the force push was just to start the check for the CLA.
yes please resolve the conflict.

@aentinger
Copy link
Contributor

Hi @JAndrassy ☕ 👋 can you check that your merges are in? (They should be).

@aentinger aentinger merged commit e19a1b6 into arduino:main Jan 9, 2024
13 checks passed
@JAndrassy
Copy link
Contributor Author

looks OK. thank you

@JAndrassy JAndrassy deleted the ethernet_debugging branch January 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants