-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EthernetC33 debugging #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Looks like this branch is kept from merging by the license/cla check not bring signed. Can you sign the CLA agreement? Likely you've already signed it, but maybe you made this commit with a different email address? (This is a known cause for CLA errors). |
f90c10a
to
695dc02
Compare
695dc02
to
fc6aad0
Compare
Update: wasn't a CLA issue but a merge conflict with |
75e25c7
to
e9afdb0
Compare
Why the force-push? Now there's another merge-conflict 😉 . You'd have needed to |
sorry, the force push was just to start the check for the CLA. |
e9afdb0
to
fc6aad0
Compare
Hi @JAndrassy ☕ 👋 can you check that your merges are in? (They should be). |
looks OK. thank you |
the missing
volatile
onbool dhcp_acquired
in CNetIf.h caused problems for WiFi DHCP too. The waiting for DHCP ended only on timeout, but status() check then was OK because the IP address was set. So WiFi.begin just took long time.I use Uno R4 to test Renesas Core LwIP networking. For WiFi I have an esp32 with the Hosted firmware on SPI and for Ethernet I replaced the EthernetDriver implementation with one over the W5500 driver (Ethernet 2 shied) from the esp8266 core. So I use
Ethernet.begin
methods with the MAC address parameter where some of this bugs appeared. The missingrestartAsyncRequest();
insetMacAddress
stopped the periodic task so DHCP then timed out. After that I had in EthernetDriver a buffer smaller than the DHCP packet and the code just hang. It was the the assert in CEth::output).tested with LegacyEthernetTest
EthernetDriverW5500.cpp should work on Portenta C33 with MKR ETH shield too