Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed encoding of KeySlot ID. #217

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fixed encoding of KeySlot ID. #217

merged 1 commit into from
Jan 9, 2024

Conversation

lagosantol
Copy link
Contributor

KeySlot was incorrectly encoded in a single byte.
As per https://github.com/NXPPlugNTrust/nano-package?tab=readme-ov-file#mbedtls-alt-files it should be stored over 4 bytes, in Big Endian order.

@lagosantol
Fixed encoding of KeySlot ID.
e104e77 
KeySlot was incorrectly encoded in a single byte.
As per https://github.com/NXPPlugNTrust/nano-package?tab=readme-ov-file#mbedtls-alt-files it should be stored over 4 bytes, in Big Endian order.
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 20, 2023
@facchinm facchinm requested a review from pennam December 20, 2023 10:31
pennam
pennam approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pennam pennam mentioned this pull request Dec 20, 2023
Closed
@pennam
Copy link
Contributor

pennam commented Dec 20, 2023

Thanks for the patch 🙂

@per1234 per1234 linked an issue Dec 20, 2023 that may be closed by this pull request
SE05x KeyID is not correctly encoded into the private key reference #216
Closed
@pennam pennam merged commit 031f36e into arduino:main Jan 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam pennam approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SE05x KeyID is not correctly encoded into the private key reference
4 participants
@lagosantol @CLAassistant @pennam @per1234