New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFiS3 - static IP config, fix automatic DNS IP #173

Merged

facchinm merged 1 commit into arduino:main from JAndrassy:wifis3_config_auto_dns

Nov 13, 2023

Contributor

JAndrassy commented Nov 4, 2023 •

edited

Loading

Fixes a bug which I guess was introduced while adopting void CWifi::config(IPAddress local_ip) from a copy of

void CWifi::config(IPAddress local_ip, IPAddress dns_server) {
/* -------------------------------------------------------------------------- */
   IPAddress _gw(local_ip[0],local_ip[1], local_ip[2], 1);
   IPAddress _sm(255,255,255,0);
   IPAddress dns(0,0,0,0);
   return _config(local_ip, _gw, _sm,dns_server,dns);
}


          WiFiS3 - static IP config, fix automatic DNS IP

9fe4941

per1234 added type: imperfection topic: code labels

Contributor Author

JAndrassy commented Nov 13, 2023

@facchinm this one is a simple bug

facchinm merged commit 8d0a28d into arduino:main

6 checks passed

JAndrassy deleted the wifis3_config_auto_dns branch

November 13, 2023 18:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code type: imperfection