CAN Filter and Mask #170
Merged
CAN Filter and Mask #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aentinger
requested changes
Nov 3, 2023
There was a problem hiding this comment.
Hi @Woodwarth ☕ 👋
It's a good start! 👍 I've added a couple of suggestions to improve this PR ;)
per1234
added
type: enhancement
|
Hi @Woodwarth ☕ 👋 I've made the CAN filter API more Arduino friendly. Can you please test it and tell me if this still works as you want it to work? |
|
Dont add fixed functions for setting standard/extended id's, keep it dynamic. contant with std/ext mask should be in libary and not in example |
Make a proposal. However, no internal knowledge of the library should be required. I'll be dropping your two latest commits. |
Added CAN Filter and Mask
Updated Description
Co-authored-by: Alexander Entinger <[email protected]>
Co-authored-by: Alexander Entinger <[email protected]>
Co-authored-by: Alexander Entinger <[email protected]>
Co-authored-by: Alexander Entinger <[email protected]>
… such as the layout of the mailbox groups - use clearly named methods to help the user achieve the desired outcome.
aentinger
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CAN Filter and Mask