Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFiS3 WiFiServer::accept() #144

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Sep 22, 2023

@JAndrassy
Copy link
Contributor Author

the errors in checks don't look related to this PR

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 23, 2023
@per1234
Copy link
Collaborator

per1234 commented Sep 23, 2023

the errors in checks don't look related to this PR

I concur.

The errors in the "arduino:renesas_uno:unor4wifi" job are because the project maintainers decided for some reason to configure the workflow to add jobs that compile the example sketches using the release version of the platform. The release version doesn't have the change made in this PR so the example sketch fails to compile.

The errors in the "arduino-git:renesas_uno:unor4wifi" job are because the version of the arduino/uno-r4-wifi-usb-bridge submodule doesn't declare _SERVERACCEPT due to arduino/uno-r4-wifi-usb-bridge#22 not being merged yet.

@arduino arduino deleted a comment from github-actions bot Dec 5, 2023
@JAndrassy JAndrassy force-pushed the wifis3_server_accept branch from 3390295 to aaab68b Compare February 6, 2024 18:17
@JAndrassy
Copy link
Contributor Author

PR in firmware is merged but checks still fail because extras/uno-r4-wifi-usb-bridge links to release 0.3.0 tag

@pennam pennam merged commit eb13557 into arduino:main Feb 14, 2024
5 of 7 checks passed
@JAndrassy JAndrassy deleted the wifis3_server_accept branch February 14, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants