Fix the incorrect comments in the examples of the WIFI S3 library. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
LGTM! @Hannes7eicher can you ensure that the documentation gets updated accordingly once merged? Thx |
|
@facchinm it's already updated as the article fetches the examples directly from GitHub. |
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, when I was browsing https://docs.arduino.cc/tutorials/uno-r4-wifi/wifi-examples, I noticed that the descriptions in the comments of the code were incorrect. All examples related to networking were written as RTC. So, I tried to edit the document. Later on, I found that the code in the document is based on the corresponding example code from this repository, so I made this modification here. Hope these modifications can be helpful.