Allow customization of transmit and receive buffer sizes for I2C 'Wire' object. #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions only doing type casts and forwarding are now inline which improves speed. Refactored code to more actual C++ style.
Replaced TWI_STATE preprocessor macro by enum TWI_STATE. Added #pragma once in twi.h.
optionally tweaking Wire buffer and twi buffer sizes at compile time. enum TWI_STATE : uint8_t becomes uint8_t. twi_state type changed form uint8_t to TWI_STATE. Added examples for customized buffers. Do println() after all received characters have been printed in master_reader.ino.
optionally tweaking Wire buffer and twi buffer sizes at compile time. enum TWI_STATE : uint8_t becomes uint8_t. twi_state type changed form uint8_t to TWI_STATE. Added examples for customized buffers. Do println() after all received characters have been printed in master_reader.ino. Corrected setting of transmit buffer size in example sketch. Use template struct for wire WireBuffers instead of namespace. Use only a single macro SET_WIRE_BUFFERS().
Moved constexpr.
respectively GET_Wire_BUFFERS.
|
|
|
Memory usage change @ bfde36f
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I had the need for a bigger 'Wire' buffer, I came up with this implementation.
Existing sketches work like before, but just with one additional macro in the sketch, 'Wire' will have smaller or larger buffers, and will omit unnecessary buffers. E.g. if the sketch is operating only as a master, slave buffers will be omitted. There are four new example sketches available, that demonstrate how the macro works and give evidence about the customization of the buffer sizes.
Wire buffers are still allocated at compile time.
There is also some refactoring done in regard to using C++ casts instead of C casts, making some functions inline for speed, and getting rid of static member variables.
There is corresponding pull request for the SAM architecture to allow larger or smaller buffers, but with different implementation of what buffers can be omitted in which case.
Pullrequest '#148' of ArduinoCore-sam corresponds to this pull request.