Allow tests to run on systems with case-insensitive filesystems and newer compilers. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 16 16
Lines 1072 1072
=======================================
Hits 1024 1024
Misses 48 48
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
aentinger
force-pushed
the
native_tests
branch
from
a909868 to
5e258bb
Compare
aentinger
requested changes
Sep 8, 2023
Also adds pragmas to suppress warnings treated as fatal
jboynes
force-pushed
the
native_tests
branch
from
5e258bb to
da415e6
Compare
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the test suite to run on desktop machines with case-insenstive filesystems (e.g. macOS and Windows) without needing a Linux VM or special mount point.
The main issue is the conflict between "String.h" in the api directory and the standard "string.h" include; the API's one gets matched when included with
#include <String.h>"which does not happen in a core because the include path points to the parent of the api directory. So the main change here is to alter the include path for the tests to the parent of theapidirectory to match. Unfortunately this meant modifying all the tests to includeapi/in the header filename.Testing this on macOS with XCode 13.3 (native cc which is clang 14.x) and GCC 13 also tripped over stricter warnings related to the deprecation of
sprintfand the self-move test for String. The PR includes#pragmastatements to suppress those warnings as I didn't want to change production code in this PR, saving it for separate patch.I confirmed the tests still pass on Ubuntu with GCC 12.