Bug in SoftwareSerial when using inverse logic

[jenscski]

Fix for reported bug #1361

For more further description of the bug, see http://forum.arduino.cc/index.php?topic=159726

[jenscski]

Do not set the start bit when using inverse logic, preventing the receiving end to think the transmission started when was not intentionally started.

[matthijskooijman]

Hmm, I could have sworn I saw a pulrequest for this change before, but I can't find it right now.

In any case, the change looks good to me. However, I think the commit message needs to be improved before this can be merged - it contains no information whatsover except the bug number. The commit messages should be self-contained and explain what happens and why, and additionally reference the bug report (but that's secondary).

E.g., something like:

Fix idle level when initializing a inverted SoftwareSerial

Previously, when SoftwareSerial was initialized, it would always be set
to an idle level of HIGH, even when inverted logic was enabled. Once a
byte is transmitted, the idle level gets correctly set to LOW instead.
This commit makes sure that the idle level is correct directly after
initialization already.

This fixes #1361.

[matthijskooijman]

Oh right, the PR I saw before was your other one, of course. Never mind that part of my comment :-)

[jenscski]

As far as I can tell, it's not possible to change a commit message, when first pushed.

Any help in the right direction will be helpful...

[matthijskooijman]

You can! :-)

Locally, you can change the commit message of the most recent commit using git commit --amend (hint: for older commits, you can use an "interactive rebase" - Google it if you ever need that).

To push out the changed commit to github, use git push -f, where -f means force: It "overwrites" the existing commit. github will then automatically update this pullrequest.

[jenscski]

Done :)

[matthijskooijman]

Looking good!

[cmaglie]

Thanks!