-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit use of includes from ArduinoCore-API #281
Open
TiboDevC
wants to merge
1
commit into
arduino-libraries:master
Choose a base branch
from
TiboDevC:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those files are located under the "api" directory of `ArduinoCore-API` repository https://github.com/arduino/ArduinoCore-API Those same files are also located in the ArduinoCore-samd repository https://github.com/arduino/ArduinoCore-samd and conflicting. So, to make it more explicit, specify the `api` directory.
Memory usage change @ eac3331
Click for full report table
Click for full report CSV
|
per1234
added
type: imperfection
Perceived defect in any part of project
topic: code
Related to content of the project itself
labels
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those files:
IPAddress.h
Print.h
Client.h
Server.h
Udp.h
are located under the
api
directory ofArduinoCore-API
repository https://github.com/arduino/ArduinoCore-APIThose same files are also located in the
ArduinoCore-samd
repository https://github.com/arduino/ArduinoCore-samdand conflicting.
When compiling for SAMD21, files from
ArduinoCore-samd
are used as theapi
directory is not specified while files from theArduinoCore-API
should be used.The result is a conflict of declarations (
class UDP
being declared twice for example) and compilation fails.So, this merge request explicit the
api
directory to avoid confusion and useArduinoCore-API
.